[PATCH] D47814: Teach libc++ to use native NetBSD's max_align_t

[Chandler Carruth via Phabricator via llvm-commits]

chandlerc added a comment.

(To be clear, this continues to not be related to this patch, but happy to discuss...)



================
Comment at: include/stddef.h:55
 
 // Re-use the compiler's <stddef.h> max_align_t where possible.
 #if !defined(__CLANG_MAX_ALIGN_T_DEFINED) && !defined(_GCC_MAX_ALIGN_T) && \
----------------
ldionne wrote:
> chandlerc wrote:
> > Unrelated to your patch, but this comment is now amazingly out of place.
> Nope, based on `git blame` I think it's still where it should be.
I don't understand ... I'm not saying this patch has anything to do with it. But commenting *this* block with the above comment doesn't parse for me at all... Maybe its that the wording of the comment doesn't parse for me.

Perhaps what it means is "Only provide our own max_align_t (rather than relying on a compiler-provided one) when we have to by testing for the cases where the compiler's <stddef.h> won't work."?


Repository:
  rCXX libc++

https://reviews.llvm.org/D47814