[PATCH] D49488: [LV] Move InterleaveGroup and InterleavedAccessInfo to VectorUtils.h (NFC)

Dávid Bolvanský via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 21 11:42:06 PDT 2018


xbolva00 added inline comments.


================
Comment at: include/llvm/Analysis/VectorUtils.h:263
+    int Key = SmallestKey + Index;
+    if (!Members.count(Key))
+      return nullptr;
----------------
fhahn wrote:
> xbolva00 wrote:
> > Do we need count?
> > 
> > if (Members.find(Key) == Members.end())
> >   return nullptr;
> > 
> > ?
> No need to count here I think, but I would prefer to keep this change NFC.  Feel free to fix this in the the current version in LoopVectorize.cpp. Otherwise I can make the count() change separately too.
> 
> Before submitting the patch, I will make sure it contains any changes made the LoopVectorize.cpp's version of the code. 
https://reviews.llvm.org/D51054


https://reviews.llvm.org/D49488





More information about the llvm-commits mailing list