[PATCH] D48445: [sanitizer] Use "fast mmap" kernel flag for shadow memory on macOS 10.13.4+

Kuba (Brecka) Mracek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 21 11:06:01 PDT 2018


kubamracek updated this revision to Diff 161771.
kubamracek added a comment.

> Ok. By "large" I mean extremely "large" but I guess that could also be confusing. I guess the remaining thing to address is MmapFixedNoReserve() calling internal_mmap_shadow(). I don't like MmapFixedNoReserve() (which has a name that does not imply it is for shadow memory) calling a function whose name implies it is for use for shadow memory.

I've updated the patch to now split out MmapFixedNoReserve into MmapFixedNoReserveShadow. The latter is used when allocating shadow regions.


https://reviews.llvm.org/D48445

Files:
  lib/asan/asan_rtl.cc
  lib/asan/asan_shadow_setup.cc
  lib/dfsan/dfsan.cc
  lib/esan/esan.cpp
  lib/hwasan/hwasan_linux.cc
  lib/msan/msan_linux.cc
  lib/msan/msan_poisoning.cc
  lib/sanitizer_common/sanitizer_common.h
  lib/sanitizer_common/sanitizer_fuchsia.cc
  lib/sanitizer_common/sanitizer_linux.cc
  lib/sanitizer_common/sanitizer_linux_s390.cc
  lib/sanitizer_common/sanitizer_mac.cc
  lib/sanitizer_common/sanitizer_mac.h
  lib/sanitizer_common/sanitizer_openbsd.cc
  lib/sanitizer_common/sanitizer_posix.h
  lib/sanitizer_common/sanitizer_posix_libcdep.cc
  lib/sanitizer_common/sanitizer_rtems.cc
  lib/sanitizer_common/sanitizer_win.cc
  lib/tsan/rtl/tsan_platform_posix.cc
  lib/tsan/rtl/tsan_rtl.cc

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D48445.161771.patch
Type: text/x-patch
Size: 17362 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180821/1bb9550c/attachment.bin>


More information about the llvm-commits mailing list