[PATCH] D50986: [ShrinkWrap] Don't put pseudo-instrs which use $sp before prologue setup

Francis Visoiu Mistrih via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 21 11:04:10 PDT 2018


thegameg added inline comments.


================
Comment at: test/CodeGen/Mips/shrink-wrap-buildpairf64-extractelementf64.ll:1
+; NOTE: Assertions have been autogenerated by utils/update_llc_test_checks.py
+
----------------
vstefanovic wrote:
> thegameg wrote:
> > Can you please add a MIR test with `-start-before shrink-wrap -stop-after prologepilog` instead of an IR test?
> I also need to check whether $sp is added to implicit operands in the isel pass.
> There could be a separate test for that, but I found it more convenient to cover everything with one input.
Yes, I think just `-stop-after=isel` should do it.


Repository:
  rL LLVM

https://reviews.llvm.org/D50986





More information about the llvm-commits mailing list