[PATCH] D51030: [AArch64] Optimise load(adr address) to ldr address

[Dave Green via Phabricator via llvm-commits]

dmgreen added a comment.

In https://reviews.llvm.org/D51030#1207378, @peter.smith wrote:

> - I can't see anything obviously wrong with the BFD code for handling LO19


Trying a newer ld.bfd (2.31 from today) this is working fine in both modes, so perhaps the issue is old. It was 2.27/2.28 that I was trying earlier, but the program being compiled (timeit-target) is small enough that I didn't //expect// it to go out of range.

> I think it will be worth filing a binutils bug, a quick check of the entry for aarch64-reloc.def in gold shows us:

https://sourceware.org/bugzilla/show_bug.cgi?id=23557

> If there is anything I can do to help here let me know?

I think the tls problems was me getting the code to add R_AARCH64_GOT_LD_PREL19 and R_AARCH64_TLSIE_LD_GOTTPREL_PREL19 relocations incorrect. GOT seems easy enough now I've figured out what was wrong, TLSIE I'm not sure about yet but I'm guessing it should be possible.


https://reviews.llvm.org/D51030