[PATCH] D50494: [LLD] Reserve memory in implicitly set LMARegions

Konstantin Schwarz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 21 07:22:46 PDT 2018


kschwarz updated this revision to Diff 161712.
kschwarz added a comment.

I updated the patch with parts of https://reviews.llvm.org/D50602
Additionally, two new test cases now exercise the added conditions in `isLMARegionCompatible` (thanks @ikudrin)
We are now issuing a warning if the LMA region has incompatible flags, which can lead to overlapping addresses. Both bfd and gold do not issue the warning, but fail similarly. Having a warning seems more user friendly to me.

This patch now also fixes https://bugs.llvm.org/show_bug.cgi?id=38624


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D50494

Files:
  ELF/LinkerScript.cpp
  ELF/LinkerScript.h
  test/ELF/linkerscript/at10.test
  test/ELF/linkerscript/at11.test
  test/ELF/linkerscript/at12.test
  test/ELF/linkerscript/at9.test
  test/ELF/linkerscript/vma.test

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D50494.161712.patch
Type: text/x-patch
Size: 11079 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180821/09ef9387/attachment.bin>


More information about the llvm-commits mailing list