[PATCH] D50894: Pull google/benchmark library to the LLVM tree

[Kirill Bobyrev via Phabricator via llvm-commits]

kbobyrev added inline comments.


================
Comment at: llvm/CMakeLists.txt:501
 
+option(LLVM_BUILD_BENCHMARKS "Generate build targets for the LLVM benchmarks." OFF)
+
----------------
dberris wrote:
> Is there a way to run these automatically as well, similar to the split between the `LLVM_BUILD_TESTS` and `LLVM_INCLUDE_TESTS`?
Do I understand correctly that `LLVM_INCLUDE_TESTS` adds tests to the list of default targets while `LLVM_BUILD_TESTS` simply enables/disables them?

Would you suggest the same split for benchmarks? I thought that for the first iteration we might want to leave the benchmarks "invisible" for the most users, but I can totally see how excluding them from the global list of build targets (which is the case now) can be hard for people to actually start running benchmarks.


https://reviews.llvm.org/D50894