[PATCH] D50569: Change how we handle -wrap.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: lld/ELF/SymbolTable.cpp:159
+  int &Idx2 = Symtab->SymMap[CachedHashStringRef(Real->getName())];
+  int &Idx3 = Symtab->SymMap[CachedHashStringRef(Wrap->getName())];
 
----------------
grimar wrote:
> Maybe naming with a something consistent with the arguments, like `SymIdx`, `RealIdx` and `WrapIdx` would be better?
Since these variables have very narrow scope, this kind of name should be fine. I didn't choose `SymIdx` and `RealIdx` because they don't align vertically.


https://reviews.llvm.org/D50569