[PATCH] D50330: [RFC] Implement out-of-process allocator enumeration for macOS

Kuba (Brecka) Mracek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 20 19:50:32 PDT 2018


kubamracek added a comment.

In https://reviews.llvm.org/D50330#1206984, @kcc wrote:

> I've looked at the code once more and I am really afraid of this extra complexity in the core of asan that is never needed outside of OSX/iOS. 
>  It would be much better to hide this into Mac-specific code that would use allocator's public APIs.


Just to make sure we're on the same page: You're only talking about the three added `ForEachChunkOutOfProcess` functions, right? The rest of the patch is almost entirely support/testing code that isn't adding any complexity to the core.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D50330





More information about the llvm-commits mailing list