[PATCH] D50330: [RFC] Implement out-of-process allocator enumeration for macOS

[Kostya Serebryany via Phabricator via llvm-commits]

kcc added a comment.

I've looked at the code once more and I am really afraid of this extra complexity in the core of asan that is never needed outside of OSX/iOS. 
It would be much better to hide this into Mac-specific code that would use allocator's public APIs.
It's fine to add some public APIs to the allocator for that purpose, as long as they are testable. 
Is that possible?

Also, just for my education, why would someone need to use `heap`, `vmmap`, or `leaks` on an asan-ified process? 
For leaks, we have lsan (already works on Mac IIRC). 
For `heap`, asan introduces a significant distortion so that the heap profiles won't be similar to the ones in production builds. 
For `vmmap`, part of that can be achieved by asan's builtin heap profiler (linux-only today).

You certainly know more about Mac than I do, I just want to make sure you are solving a problem that needs to be solved.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D50330