[PATCH] D51015: [MemorySSA] Make the Updater movable.

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 20 16:47:59 PDT 2018


chandlerc added inline comments.


================
Comment at: include/llvm/Analysis/MemorySSAUpdater.h:76
+    MSSA = MSSAU.MSSA;
+    MSSAU.MSSA = 0;
+    return *this;
----------------
You don't zero it out in the move constructor, why do it here? Do we do something in the destructor with it, if so it should be in both?

Also, if we do need this, s/0/nullptr/


Repository:
  rL LLVM

https://reviews.llvm.org/D51015





More information about the llvm-commits mailing list