[PATCH] D51004: [llvm-strip] Allow only one input

[Fangrui Song via Phabricator via llvm-commits]

MaskRay created this revision.
MaskRay added reviewers: alexshap, jhenderson, paulsemel.
Herald added subscribers: llvm-commits, rupprecht, jakehehrlich.

Before, llvm-strip accepted a second argument but it would just be ignored.


Repository:
  rL LLVM

https://reviews.llvm.org/D51004

Files:
  tools/llvm-objcopy/llvm-objcopy.cpp


Index: tools/llvm-objcopy/llvm-objcopy.cpp
===================================================================
--- tools/llvm-objcopy/llvm-objcopy.cpp
+++ tools/llvm-objcopy/llvm-objcopy.cpp
@@ -930,12 +930,12 @@
       T.ParseArgs(ArgsArr, MissingArgumentIndex, MissingArgumentCount);
 
   if (InputArgs.size() == 0) {
-    T.PrintHelp(errs(), "llvm-strip <input> [ <output> ]", "strip tool");
+    T.PrintHelp(errs(), "llvm-strip", "strip tool");
     exit(1);
   }
 
   if (InputArgs.hasArg(STRIP_help)) {
-    T.PrintHelp(outs(), "llvm-strip <input> [ <output> ]", "strip tool");
+    T.PrintHelp(outs(), "llvm-strip", "strip tool");
     exit(0);
   }
 
@@ -948,7 +948,7 @@
   if (Positional.empty())
     error("No input file specified");
 
-  if (Positional.size() > 2)
+  if (Positional.size() > 1)
     error("Support for multiple input files is not implemented yet");
 
   CopyConfig Config;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D51004.161585.patch
Type: text/x-patch
Size: 902 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180820/fcca70d8/attachment.bin>