[PATCH] D50929: [llvm-mca] Introduce the llvm-mca library and organize the directory accordingly. NFC.

Andrea Di Biagio via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 20 09:09:55 PDT 2018


andreadb added a comment.

My opinion is that `CodeRegion.h` and `CodeRegion.cpp` should not be part of the library. Those files implement a class which is meant to be used by the llvm-mca driver only to mark regions of code. A different utility class/approach should be used when llvm-mca is used as a library.

> I would like to place the Views and Stats into separate (non-library) directories, just to keep things better organized, but that would be a separate patch.

Any reasons why it cannot be done as part of this patch?


https://reviews.llvm.org/D50929





More information about the llvm-commits mailing list