[PATCH] D50966: Fix an undefined behavior when storing an empty StringRef.

Eric Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Aug 20 05:29:21 PDT 2018


ioeric added inline comments.


================
Comment at: lib/Support/StringSaver.cpp:14
 
 StringRef StringSaver::save(StringRef S) {
+  if (S.empty())
----------------
Is it possible to reuse `StringRef::copy(Allocator &)` here?


Repository:
  rL LLVM

https://reviews.llvm.org/D50966





More information about the llvm-commits mailing list