[PATCH] D50714: [InstCombine] Fold Select with binary op - FP opcodes

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Aug 19 10:07:19 PDT 2018


spatel added a comment.

In https://reviews.llvm.org/D50714#1205336, @xbolva00 wrote:

> Alive says that we cannot transform it. OEQ maybe yes with the check if zero has no sign.
>
> Alive: https://pastebin.com/TkJB4RTr


Great! You got alive-nj working.

So yes, looks like we have to check for 'nsz' and only OEQ (but not UEQ). For the tests, there's no easy way to encode what we're showing here AFAIK. We just need to make sure that we have both positive and negative tests when 'nsz' is (not) there and for each possible predicate.


https://reviews.llvm.org/D50714





More information about the llvm-commits mailing list