[PATCH] D47196: [Time-report ](2): Recursive timers in Clang

Andrew V. Tischenko via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Aug 17 04:16:00 PDT 2018


avt77 added a comment.

In https://reviews.llvm.org/D47196#1202805, @efriedma wrote:

> > :start: means the timer was started
>
> In some cases, the ChildTime is already non-zero at the "start" point; what does that mean?


It means there was recursive call and this child time should be removed from the time of the current func (parent) otherwise it could be calculated twice.

>> ActOnFunctionDeclarator:start:....._exception:
> 
> That's weird... DeclarationName::print should generally return something ASCII; do you know what kind of declaration it is?

There are a lot of such names (see the attach as example.)F6964637: b.log <https://reviews.llvm.org/F6964637>
BTW, I use getNameAsString() (see getFirstName). I tried getIdentifier () ->getName() but it was broken rather often.


https://reviews.llvm.org/D47196





More information about the llvm-commits mailing list