[PATCH] D50867: [InstrProf] Use atomic profile counter updates for TSan

JF Bastien via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 16 14:43:01 PDT 2018


jfb added inline comments.


================
Comment at: llvm/lib/Transforms/Instrumentation/InstrProfiling.cpp:608
+    Builder.CreateAtomicRMW(AtomicRMWInst::Add, Addr, Inc->getStep(),
+                            AtomicOrdering::SequentiallyConsistent);
+  } else {
----------------
Counters could just be `relaxed`, no need to use `seq_cst`.


https://reviews.llvm.org/D50867





More information about the llvm-commits mailing list