[PATCH] D50656: [X86] In EFLAGS copy pass, don't emit EXTRACT_SUBREG instructions since we're after peephole

Chandler Carruth via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 16 14:27:55 PDT 2018


chandlerc accepted this revision.
chandlerc added a comment.
This revision is now accepted and ready to land.

Yikes, good catch! LGTM.



================
Comment at: test/CodeGen/X86/pr38539.ll:5
+
+; This test is targeted at 64-bit mode. It used to crash due to the creation of an EXTRACT_SUBREG after the peephole pass had ran.
+define void @f() {
----------------
nit: 80-columns?


================
Comment at: test/CodeGen/X86/pr38539.ll:176
+
+; Similar to above, but bitwidth adjusted to target 32-bit mode. This also shows that we didn't constrain the register class when extracting a subreg.
+define void @g() {
----------------
nit: 80-columns


https://reviews.llvm.org/D50656





More information about the llvm-commits mailing list