[PATCH] D50213: DebugInfo: Add metadata support for disabling DWARF pub sections

David Blaikie via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 16 14:07:33 PDT 2018


dblaikie added a comment.

In https://reviews.llvm.org/D50213#1202568, @aprantl wrote:

> Sorry, my mistake. I saw that you added a new field in the IR assembler and sloppily assumed that there is also a new bitcode record for it, but there isn't, so the whole point is moot.


Oh, no worries - yeah, it is certainly a bit subtle. Appreciate you taking the time/care to be sure.

Patch seem good all-up now?

(one or two patches to follow - flags in Clang to enable/disable pubnames, along with default behavior to disable pubnames in DWARF5)


Repository:
  rL LLVM

https://reviews.llvm.org/D50213





More information about the llvm-commits mailing list