[PATCH] D35722: [DAGCombine] Improve (sra (sra x, c1), c2) -> (sra x, (add c1, c2)) folding

Simon Pilgrim via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 16 12:45:36 PDT 2018


RKSimon added a comment.

In https://reviews.llvm.org/D35722#1202997, @spatel wrote:

> LGTM. I notice we don't fold the non-splat case of this pattern in IR. Do you think it's worth adding there too, or backend is good enough?


Add it if you can, properly supporting vectors is always a good idea ;-)

Is there the equivalent logical shifts -> zero combine?


Repository:
  rL LLVM

https://reviews.llvm.org/D35722





More information about the llvm-commits mailing list