[llvm] r339925 - [WebAssembly] Remove temporary workaround for function bitcasts

Jacob Gravelle via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 16 12:24:32 PDT 2018


Author: jgravelle
Date: Thu Aug 16 12:24:31 2018
New Revision: 339925

URL: http://llvm.org/viewvc/llvm-project?rev=339925&view=rev
Log:
[WebAssembly] Remove temporary workaround for function bitcasts

Summary:
EM_ASM no longer is lowered as varargs in C, so this workaround is
obsolete.

Reviewers: dschuff, sunfish

Subscribers: sbc100, aheejin, llvm-commits

Differential Revision: https://reviews.llvm.org/D50859

Modified:
    llvm/trunk/lib/Target/WebAssembly/WebAssemblyFixFunctionBitcasts.cpp

Modified: llvm/trunk/lib/Target/WebAssembly/WebAssemblyFixFunctionBitcasts.cpp
URL: http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/WebAssembly/WebAssemblyFixFunctionBitcasts.cpp?rev=339925&r1=339924&r2=339925&view=diff
==============================================================================
--- llvm/trunk/lib/Target/WebAssembly/WebAssemblyFixFunctionBitcasts.cpp (original)
+++ llvm/trunk/lib/Target/WebAssembly/WebAssemblyFixFunctionBitcasts.cpp Thu Aug 16 12:24:31 2018
@@ -257,11 +257,6 @@ bool FixFunctionBitcasts::runOnModule(Mo
     if (!Ty)
       continue;
 
-    // Bitcasted vararg functions occur in Emscripten's implementation of
-    // EM_ASM, so suppress wrappers for them for now.
-    if (TemporaryWorkarounds && (Ty->isVarArg() || F->isVarArg()))
-      continue;
-
     auto Pair = Wrappers.insert(std::make_pair(std::make_pair(F, Ty), nullptr));
     if (Pair.second)
       Pair.first->second = CreateWrapper(F, Ty);




More information about the llvm-commits mailing list