[PATCH] D50858: [M680x0] Add ELF and Triple info

Artyom Goncharov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 16 12:20:45 PDT 2018


m4yers added a comment.

In https://reviews.llvm.org/D50858#1202964, @lebedev.ri wrote:

> I'm not sure how ELF/relocation stuff should be tested, but i *think* it can also be split into a second review.
> Though
>
>   llvm/test$ find -iname *Relocs*
>
>
> does find some things.


There are tests for relocations in the main diff https://reviews.llvm.org/D50314 `test/CodeGen/M680x0/OBJ/Relocations`, but those require the full backend available. Aside from that I'm not really sure how to test them in a separate diff. For now they are just data copied from the m68k manual.

> Please add appropriate test coverage to unittests/ADT/TripleTest.cpp.

Will do


Repository:
  rL LLVM

https://reviews.llvm.org/D50858





More information about the llvm-commits mailing list