[PATCH] D50823: [VPlan] Introduce VPCmpInst sub-class in the instruction-level representation

[Robin Kruppe via Phabricator via llvm-commits]

rkruppe added a comment.

In https://reviews.llvm.org/D50823#1202955, @hsaito wrote:

> Our general intention is to make VPInstructions as easy to use as Instructions to many LLVM developers, who aren't necessarily very familiar with vectorizer, and also reduce the duplicate development/maintenance effort. If that requires more subclassing, we'll consider doing that but very carefully, and only as needed basis. At this point, letting VPInstruction to have all the functionality of Instruction is not an objective. We are starting from implementing just enough to satisfy vectorizer needs and minimizing unnecessary divergence in doing so (i.e., what's implemented can be used in a very similar manner).
>
> Sorry that I'm not directly answering your question. Hope this helps in evaluating between the two alternatives:  new opcode approach in https://reviews.llvm.org/D50480 and subclassing approach in this patch, however. I think subclassing here helps us avoid unnecessary divergence.


Thanks, it doesn't answer my question in the exact terms I used, but it hits all the notes I was curious about. I agree with the goals (accessibility to developers, minimizing unnecessary divergence) and also with getting there incrementally and on demand.


Repository:
  rL LLVM

https://reviews.llvm.org/D50823