[PATCH] D50784: [TableGen] Add Instruction custom byte sequence emission

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri added a comment.

Is there some testing approach for changes like this?
It really isn't ideal to just use the final use-case (the target) as the one any testing strategy for this.



================
Comment at: utils/TableGen/CodeBeadsGen.cpp:13-14
+/// defined for an instruction. They are used to pass very target specific
+/// binary information directly from a tablegen file, e.g. instruction
+/// encoding.
+///
----------------
Ignorant question: but surely the problem of storing instruction encoding in tablegen has already arose?
How does this solution differ from the existing practice?


Repository:
  rL LLVM

https://reviews.llvm.org/D50784