[PATCH] D50859: [WebAssembly] Remove temporary workaround for function bitcasts

Jacob Gravelle via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 16 11:33:05 PDT 2018


jgravelle-google created this revision.
jgravelle-google added reviewers: dschuff, sunfish.
Herald added subscribers: aheejin, sbc100.

EM_ASM no longer is lowered as varargs in C, so this workaround is
obsolete.


Repository:
  rL LLVM

https://reviews.llvm.org/D50859

Files:
  lib/Target/WebAssembly/WebAssemblyFixFunctionBitcasts.cpp


Index: lib/Target/WebAssembly/WebAssemblyFixFunctionBitcasts.cpp
===================================================================
--- lib/Target/WebAssembly/WebAssemblyFixFunctionBitcasts.cpp
+++ lib/Target/WebAssembly/WebAssemblyFixFunctionBitcasts.cpp
@@ -257,11 +257,6 @@
     if (!Ty)
       continue;
 
-    // Bitcasted vararg functions occur in Emscripten's implementation of
-    // EM_ASM, so suppress wrappers for them for now.
-    if (TemporaryWorkarounds && (Ty->isVarArg() || F->isVarArg()))
-      continue;
-
     auto Pair = Wrappers.insert(std::make_pair(std::make_pair(F, Ty), nullptr));
     if (Pair.second)
       Pair.first->second = CreateWrapper(F, Ty);


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D50859.161083.patch
Type: text/x-patch
Size: 682 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180816/75cf4007/attachment.bin>


More information about the llvm-commits mailing list