[PATCH] D50798: [LoopVectorizer] Take into account call register pressure when selecting interleave count

Robert Lougher via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 16 10:43:03 PDT 2018


rob.lougher added inline comments.


================
Comment at: lib/Target/X86/X86TargetTransformInfo.cpp:191
+unsigned X86TTIImpl::getNumberOfCallPreservedRegisters(bool Vector) {
+  if (ST->isOSWindows())
+    return 8;
----------------
grandinj wrote:
> perhaps an
> 
>     assert(hasNumberOfCallPreservedRegisters() && "you need to call hasNumberOfCallPreservedRegisters before calling this")
> 
> would be a good idea here, to catch incorrect usage?
> 
Yes, excellent idea. I'll add an assert to the function in TargetTransformInfo.cpp, before calling the TTIImpl.


Repository:
  rL LLVM

https://reviews.llvm.org/D50798





More information about the llvm-commits mailing list