[PATCH] D50851: [codeview] Use push_macro to avoid conflicts instead of a prefix

[Reid Kleckner via Phabricator via llvm-commits]

rnk created this revision.
rnk added reviewers: zturner, JDevlieghere.
Herald added a subscriber: hiraditya.

This prefix was added in r333421, and it changed our dumper output to
say things like "CVRegEAX" instead of just "EAX". That's a functional
change that I'd rather avoid.

I tested GCC, Clang, and MSVC, and all of them support #pragma
push_macro. They don't issue warnings whem the macro is not defined
either.

I don't have a Mac so I can't test the real termios.h header, but I
looked at the termios.h sources online and looked for other conflicts.
I saw only the CR* macros, so those are the ones we work around.


https://reviews.llvm.org/D50851

Files:
  lld/test/COFF/pdb-type-server-simple.test
  llvm/include/llvm/DebugInfo/CodeView/CodeViewRegisters.def
  llvm/lib/DebugInfo/PDB/Native/NativeRawSymbol.cpp
  llvm/lib/Target/X86/MCTargetDesc/X86MCTargetDesc.cpp
  llvm/test/DebugInfo/COFF/fp-stack.ll
  llvm/test/DebugInfo/COFF/local-variable-gap.ll
  llvm/test/DebugInfo/COFF/local-variables.ll
  llvm/test/DebugInfo/COFF/pieces.ll
  llvm/test/DebugInfo/COFF/register-variables.ll
  llvm/test/DebugInfo/COFF/types-array.ll
  llvm/test/DebugInfo/PDB/DIA/pdbdump-symbol-format.test
  llvm/test/DebugInfo/X86/dbg-declare-inalloca.ll
  llvm/test/MC/COFF/cv-def-range-gap.s
  llvm/unittests/DebugInfo/CodeView/TypeIndexDiscoveryTest.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D50851.161057.patch
Type: text/x-patch
Size: 47736 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180816/1121f3e0/attachment-0001.bin>