[PATCH] D45961: [MC] Add MCSubtargetInfo to MCAlignFragment [NFC]

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 16 10:25:10 PDT 2018


peter.smith updated this revision to Diff 161052.
peter.smith edited the summary of this revision.
peter.smith added a comment.

I've uploaded a new version that doesn't use getLastSubtargetInfo(). Thanks for the warning about clang tools/driver/cc1as_main.cpp I've not seen anywhere else in the project that uses InitSections(). The code there will become:

  Str.get()->InitSections(Opts.NoExecStack, *STI);

As the STI has been computed earlier.  I'm happy to post another review if people prefer? Otherwise I could just make the change immediately after where this to be committed.


https://reviews.llvm.org/D45961

Files:
  include/llvm/MC/MCELFStreamer.h
  include/llvm/MC/MCFragment.h
  include/llvm/MC/MCObjectStreamer.h
  include/llvm/MC/MCStreamer.h
  include/llvm/MC/MCWinCOFFStreamer.h
  lib/CodeGen/AsmPrinter/AsmPrinter.cpp
  lib/MC/ConstantPools.cpp
  lib/MC/MCAsmStreamer.cpp
  lib/MC/MCELFStreamer.cpp
  lib/MC/MCObjectStreamer.cpp
  lib/MC/MCParser/AsmParser.cpp
  lib/MC/MCStreamer.cpp
  lib/MC/MCWinCOFFStreamer.cpp
  lib/Target/AArch64/AArch64AsmPrinter.cpp
  lib/Target/ARM/ARMAsmPrinter.cpp
  lib/Target/ARM/ARMMCInstLower.cpp
  lib/Target/ARM/AsmParser/ARMAsmParser.cpp
  lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp
  lib/Target/Hexagon/AsmParser/HexagonAsmParser.cpp
  lib/Target/Hexagon/HexagonAsmPrinter.cpp
  lib/Target/Mips/MCTargetDesc/MipsTargetStreamer.cpp
  lib/Target/Mips/MipsAsmPrinter.cpp
  lib/Target/PowerPC/PPCAsmPrinter.cpp
  lib/Target/X86/AsmParser/X86AsmParser.cpp
  lib/Target/X86/X86MCInstLower.cpp
  tools/llvm-mc/Disassembler.cpp
  tools/llvm-mc/llvm-mc.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D45961.161052.patch
Type: text/x-patch
Size: 23608 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180816/8a6f18fa/attachment.bin>


More information about the llvm-commits mailing list