[PATCH] D50846: [ARM][NFC] ARMCodeGenPrepare: some refactoring and algorithm description.

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Aug 16 08:51:56 PDT 2018


samparker accepted this revision.
samparker added a comment.
This revision is now accepted and ready to land.

Thanks for putting the time into this, just one nit before its committed please.



================
Comment at: lib/Target/ARM/ARMCodeGenPrepare.cpp:606
 
-  // Return true if the given value can, or has been, visited. Add V to the
-  // worklist if needed.
+  // Return true if V was added to the worklist as a supported instruction, or
+  // when it was already visited, and false otherwise.
----------------
or we don't need to explore it, such as pointer values and gep instructions.


https://reviews.llvm.org/D50846





More information about the llvm-commits mailing list