[PATCH] D50744: [llvm-strip] Add support for -p/--preserve-dates

[James Henderson via Phabricator via llvm-commits]

jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

If I get a chance, I'll verify this on Windows. Otherwise, this LGTM.



================
Comment at: test/tools/llvm-objcopy/strip-preserve-time.test:5
+# RUN: yaml2obj %s > %t.o
+# RUN: touch -a -t 199505050555.55 %t.o
+# RUN: touch -m -t 199705050555.55 %t.o
----------------
rupprecht wrote:
> jhenderson wrote:
> > I'm slightly worried that this might lead to a flaky test, because there's a race condition here: if another process accesses the file some time between file creation and checking, then we'll presumably get a failure (and I could see a virus scanner doing just that...).
> I'm not sure if there's a good solution for this. At the very least, I can watch build bots once this is submitted to see if this test causes flakiness. Very little time goes by between file creation and running llvm-strip, so it _probably_ won't cause issues, but I don't know how virus scanners work.
Yeah, I don't really know either. If it starts causing flakiness, we might just want to sacrifice that part of the test, and just verify it manually...


================
Comment at: test/tools/llvm-objcopy/strip-preserve-time.test:34
+# RUN: rm -f %t.a
+# RUN: llvm-ar crs %t.a %t.5.o
+# RUN: touch -a -t 199505050555.55 %t.a
----------------
Nit: I don't think you need the 's' part of this command.


Repository:
  rL LLVM

https://reviews.llvm.org/D50744