[PATCH] D50742: [ELF] mergeSections: remove non-alive MergeInputSection

[George Rimar via Phabricator via llvm-commits]

grimar accepted this revision.
grimar added a comment.
This revision is now accepted and ready to land.

LGTM with a nit.



================
Comment at: test/ELF/x86-64-reloc-error2.s:13
+# If .rodata.str1 is kept, cast<InputSection>(D) in getErrPlace will cause an assertion failure.
+.section .rodata.str1,"aMS", at progbits,1
+.asciz "a"
----------------
You do not need to reveal the implementation details in the test cases.
They might change and will make such comment outdated.

All you need is to say is something like:
"This mergeable section will be garbage collected. We had a crash issue in that case. Test it."


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D50742