[PATCH] D48879: [XRay][test-suite] Benchmarks for profiling mode implementation

[Hans Wennborg via Phabricator via llvm-commits]

hans added a comment.

In https://reviews.llvm.org/D48879#1199290, @dberris wrote:

> In https://reviews.llvm.org/D48879#1199118, @hans wrote:
>
> > In https://reviews.llvm.org/D48879#1199017, @dberris wrote:
> >
> > > I could reproduce locally, and so I had a look but this time I needed to rebuild on a clean build dir. PTAL?
> >
> >
> > I ran "make clean" on it and tried again, but with the same result
>
>
> I found that 'make clean' doesn't quite cut it unfortunately, I needed to have a full clean build -- I suspect this is because the lit config is copied/cached when building/running the tests?


I tried with a new build dir like this:

  $ CC=/work/llvm-7.0/build.clang6/bin/clang CXX=/work/llvm-7.0/build.clang6/bin/clang++ cmake -GNinja ../test-suite -DTEST_SUITE_LIT=/work/llvm-7.0/build.clang6/bin/llvm-lit
  $ ninja check

but got the same error.

> Either that or the version that's in 7.0 doesn't have some recent changes to profiling mode. I have been testing with the latest from trunk.

I tried using trunk, but got compile errors:

  /work/test-suite/MicroBenchmarks/XRay/ProfilingMode/profiling-bench.cc:33:7: error: use of undeclared identifier '__xray_log_init_mode'; did you mean '__xray_log_register_mode'?
    if (__xray_log_init_mode("xray-profiling", "no_flush=true") !=
        ^~~~~~~~~~~~~~~~~~~~
        __xray_log_register_mode
  /work/llvm/build.release/lib/clang/8.0.0/include/xray/xray_log_interface.h:226:23: note: '__xray_log_register_mode' declared here
  XRayLogRegisterStatus __xray_log_register_mode(const char *Mode,
                        ^
  /work/test-suite/MicroBenchmarks/XRay/ProfilingMode/profiling-bench.cc:33:46: error: no viable conversion from 'const char [14]' to 'XRayLogImpl'
    if (__xray_log_init_mode("xray-profiling", "no_flush=true") !=
                                               ^~~~~~~~~~~~~~~
  /work/llvm/build.release/lib/clang/8.0.0/include/xray/xray_log_interface.h:155:8: note: candidate constructor (the implicit copy constructor) not viable: no known conversion from 'const char [14]' to 'const XRayLogImpl &' for 1st argument
  struct XRayLogImpl {
         ^
  /work/llvm/build.release/lib/clang/8.0.0/include/xray/xray_log_interface.h:155:8: note: candidate constructor (the implicit move constructor) not viable: no known conversion from 'const char [14]' to 'XRayLogImpl &&' for 1st argument
  /work/llvm/build.release/lib/clang/8.0.0/include/xray/xray_log_interface.h:227:60: note: passing argument to parameter 'Impl' here
                                                 XRayLogImpl Impl);
                                                             ^
  2 errors generated.


Repository:
  rT test-suite

https://reviews.llvm.org/D48879