[PATCH] D44501: COFF: Move assignment of section offsets to assignAddresses(). NFCI.

[Martin Storsjö via Phabricator via llvm-commits]

mstorsjo added a comment.

In https://reviews.llvm.org/D44501#1200976, @pcc wrote:

> In https://reviews.llvm.org/D44501#1200972, @smeenai wrote:
>
> > In https://reviews.llvm.org/D44501#1200324, @mstorsjo wrote:
> >
> > > > This makes the design a little more similar to the ELF linker and should allow for features such as ARM range extension thunks to be implemented more easily.
> > >
> > > @pcc - I found you mentioned this as part of this change; do you have any concrete plan on how to add ARM range extension thunks? I'm pondering giving that a try, but if you have ideas about how/where to start, that'd get me started quicker.
> >
> >
> > Have you looked at their design in the ELF port? CC @peter.smith, who added that support.
>
>
> Yes, I was broadly imagining that it would work in a similar way to the ELF port.


I tried to look briefly at the commit that added the range extension thunks for ELF, but I guess I should look at more of it than that commit, since it seemed to rely on some generic thunking support that existed before. Or perhaps I should just have another look.


Repository:
  rL LLVM

https://reviews.llvm.org/D44501