[PATCH] D50213: DebugInfo: Add metadata support for disabling DWARF pub sections

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a comment.

In https://reviews.llvm.org/D50213#1201350, @aprantl wrote:

> >> Can you add a bitcode upgrade test?
> > 
> > I could - but I'm not sure it would test anything. The format has in some sense remained the same - this field is still zero/one before/after the change, but now new values are also valid.
> >  Reckon it's still worth testing? What do you reckon that testing would cover?
>
> It would be sufficient to find an existing .bc file with a DICompileUnit in it and add a CHECK: that tests that the new flag comes out as default(=0) (which probably means it won't be printed at all, but that's fine).


Still not sure I follow - the flag isn't new in the bitcode format. In the old format it could have the values {0, 1} and in the new format it can have the values {0, 1, 2}.

So an old .ll file with "gnuPubnames: false" or "gnuPubnames: true" against an old llc would produce the same bitcode as a new .ll with "nameTable: Default" and "nameTable: GNU". So checking in a bitcode file doesn't seem like it would test anything new/different, to me?


Repository:
  rL LLVM

https://reviews.llvm.org/D50213