[PATCH] D49678: [llvm-objcopy] Adding support for compressed DWARF debug sections.

[Puyan Lotfi via Phabricator via llvm-commits]

plotfi marked 3 inline comments as done.
plotfi added a comment.

In https://reviews.llvm.org/D49678#1200360, @jhenderson wrote:

> Could I make one request going forwards. It's helpful if you post a quick summary of the changes you made each time you update the diff (a bullet-point list would be fine). Due to the scale of the change, I'd prefer not to re-review everything each time I look, and sometimes it's a little hard to remember whether a bit has changed.


Ah, sorry about that. I was just checking what was done based on your suggestions. Will do.

> In https://reviews.llvm.org/D49678#1199294, @plotfi wrote:
> 
>>
> 
> 
> 
> 
>> I did. There seem to have been changes since I submitted. I'd like to be able to push this soon. Is there anything else that needs addressing aside from the test names/content and comments?
> 
> This change is certainly improving, but there are still a few things I'd like addressing (see inline comments). I also want @jakehehrlich to comment on the ELFT-related changes.





================
Comment at: test/tools/llvm-objcopy/Inputs/compress-debug-sections.yaml:1
+--- !ELF
+FileHeader:
----------------
plotfi wrote:
> jhenderson wrote:
> > Are you planning any more updates to this test? Because I still don't see why you need such a large section.
> > 
> > You also definitely don't need the GNU stack section, or the symbols.
> > 
> > I think that one thing that is important is having relocations patching the debug section, because these need to point at the decompressed offset, not something else. You should add one that patches somewhere in the middle of your (small) section, and another that uses a section-relative reference and addend, referencing the compressed section.
> > 
> > Finally, you should have testing that shows that non-debug sections are not compressed.
> Ah, alright. I'll add back the comment section. I made the content somewhat large so that the compression would actually make it smaller (and not bail out). I can also add the relocation sections back too. I had trouble removing the stack section. I'll try and remove it through llvm-objcopy.
James are you saying I need to also manually update sections like .rela.debug_line ??


Repository:
  rL LLVM

https://reviews.llvm.org/D49678