[PATCH] D50343: [llvm-objcopy] Add support for -I binary -B <arch>.

Jordan Rupprecht via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 15 11:22:51 PDT 2018


rupprecht added a comment.

In https://reviews.llvm.org/D50343#1200318, @jhenderson wrote:

> LGTM, but there is one thing still outstanding, I think, which @jakehehrlich mentioned in a comment regarding the CopyConfig options:
>
> > A pattern of grouping by type does seem to have formed organically however. Let's stick with it.
>
> I don't have a strong preference either way, but you should get @jakehehrlich to confirm he is happy before committing this change.


Ok, I split out each section by type + alphabetized (as suggested after that comment). I also don't have any strong preference though; I'm happy to apply whatever organization/comments/etc. others want here.

There was also a suggestion in that comment to rename config names to more closely match flag names which is also a good idea, but I'd rather submit that as an NFC after this to avoid putting myself in merge conflict hell :)


Repository:
  rL LLVM

https://reviews.llvm.org/D50343





More information about the llvm-commits mailing list