[PATCH] D48790: Update MemorySSA in Local utils removing blocks.

[Alina Sbirlea via Phabricator via llvm-commits]

asbirlea marked an inline comment as done.
asbirlea added inline comments.


================
Comment at: lib/Transforms/Utils/Local.cpp:2231
 
+  // FIXME: May reuse this set below if deletion order does not matter.
+  SmallPtrSet<BasicBlock *, 16> DeadBlockSet;
----------------
NutshellySima wrote:
> Yes, I think the deletion order doesn't matter.
It seems to make sense to use this in the first iteration over the blocks in F that follows, but not the second one doing the erase, since that's better to be iterator based.
Also search DeadBlockSet instead of Reachable, assuming more blocks are live than dead.


Repository:
  rL LLVM

https://reviews.llvm.org/D48790