[PATCH] D50658: Hot cold splitting pass

Krzysztof Parzyszek via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 15 07:48:37 PDT 2018


kparzysz added a comment.

This looks good.  Do you have a testcase that demonstrates what this pass does?



================
Comment at: lib/Transforms/IPO/HotColdSplitting.cpp:209
+      // Get cold region
+      BasicBlock *Exit = PDT[BB]->getIDom()->getBlock();
+      SmallVector<BasicBlock *, 4> Region;
----------------
Another thing for the future development would be to find the largest cold section of the code: for example, if there are two adjacent loops that are both in a cold side of an if-statement, both of them could be outlined into the same function.


https://reviews.llvm.org/D50658





More information about the llvm-commits mailing list