[PATCH] D45961: [MC] Add MCSubtargetInfo to MCAlignFragment [NFC]

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 15 06:51:46 PDT 2018


asb added a comment.

You will also need to patch at least clang tools/driver/cc1as_main.cpp due to the change to InitSections.

Mechanically the changes seem fine. There's one aspect I'd appreciate further comment on: having to perform getLastSubtargetInfo seems pragmatic but feels ugly. Are there cases where this might be incorrect? Should there be a FIXME indicating that some superior solution for ensuring access to an appropate MCSubtargetInfo should be implemented?


https://reviews.llvm.org/D45961





More information about the llvm-commits mailing list