[PATCH] D45960: [MC] Add MCSubtargetInfo to MCPaddingFragment [NFC]

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 15 06:37:35 PDT 2018


asb accepted this revision.
asb added a comment.
This revision is now accepted and ready to land.

Other than two tiny formatting issues, this looks good to me.



================
Comment at: include/llvm/MC/MCFragment.h:382
 
-  MCPaddingFragment(MCSection *Sec = nullptr)
+  MCPaddingFragment(const MCSubtargetInfo& STI, MCSection *Sec = nullptr)
       : MCFragment(FT_Padding, false, Sec), PaddingPoliciesMask(PFK_None),
----------------
Normal LLVM style would be `const MCSubtargetInfo &STI`


================
Comment at: include/llvm/MC/MCObjectStreamer.h:79
   MCDataFragment *getOrCreateDataFragment(const MCSubtargetInfo* STI = nullptr);
-  MCPaddingFragment *getOrCreatePaddingFragment();
+  MCPaddingFragment *getOrCreatePaddingFragment(const MCSubtargetInfo& STI);
 
----------------
Normal LLVM style would be `const MCSubtargetInfo &STI`


https://reviews.llvm.org/D45960





More information about the llvm-commits mailing list