[PATCH] D49879: [PowerPC] Generate Power9 extswsli extend sign and shift immediate instruction

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Aug 15 06:18:49 PDT 2018


nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.

LGTM aside from the minor nit.



================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:14118
+      N0.getOperand(0).getValueType() != MVT::i32 ||
+      CN1 == NULL)
+    return SDValue();
----------------
Nit: please change `CN1 == NULL` to either `!CN1` or `CN1 == nullptr`. Feel free to do this on the commit - no new review required.


https://reviews.llvm.org/D49879





More information about the llvm-commits mailing list