[PATCH] D50668: unittests: Don't install TestPlugin.so

Tom Stellard via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 14 11:59:38 PDT 2018


tstellar added a comment.

In https://reviews.llvm.org/D50668#1198585, @philip.pfaffe wrote:

> This makes complete sense to me, but I'm wondering whether add_llvm_loadable_module is the right macro to use here in the first place. All it does is call add_llvm_library with a MODULE argument, and set up the install.
>
> So it seems to me that add_llvm_library(TestPlugin MODULE BUILDTREE_ONLY ...) should work just as well, without changing the setup. Does that make sense?


That's a better idea.  I've updated the patch.


Repository:
  rL LLVM

https://reviews.llvm.org/D50668





More information about the llvm-commits mailing list