[PATCH] D45300: Update MemorySSA BasicBlockUtils.

Alina Sbirlea via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 14 10:58:59 PDT 2018


asbirlea added a comment.

Thank you for the comments!

I don't have testcases just for this change.
There are a couple of dependent patches in Phabricator (e.g. https://reviews.llvm.org/D45301, https://reviews.llvm.org/D47022 need to be rebased) that will use these changes.
The use of MemorySSA is disabled by default, but the dependent patches will update tests with a target that enables the use of MemorySSA (e.g. see tests in https://reviews.llvm.org/D40375).

Yes, I think the changes to MergeBlockIntoPredecessor could be split, but the overall purpose of adding an additional analysis to update is the same and the scope of the changes is fairly small. 
If you think it will help review or clarity, I can split this up.


Repository:
  rL LLVM

https://reviews.llvm.org/D45300





More information about the llvm-commits mailing list