[PATCH] D50717: [NFC][SimplifyCFG] Remove pointer from SmallPtrSet before deletion

Dave Green via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 14 10:05:31 PDT 2018


dmgreen added a comment.

I'm no expert, but I thought that SmallPtrSet->erase(BB) would treat BB as an opaque value that it removes from it's set, not accessing it's content in any way. You may be right about the eraseFromParent invalidating things though.

It's certainly much better this new way :)


Repository:
  rL LLVM

https://reviews.llvm.org/D50717





More information about the llvm-commits mailing list