[PATCH] D47143: [InstrSimplify, NewGVN] Add option to ignore additional instr info when simplifying.

Aditya Kumar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 14 09:38:07 PDT 2018


hiraditya added a comment.

LGTM with the minor nit.



================
Comment at: include/llvm/Analysis/InstructionSimplify.h:85
+    if (UseInstrInfo)
+      return cast<PossiblyExactOperator>(Op)->isExact();
+    return false;
----------------
I see other places use isa to first check if BinaryOperator isa PossiblyExactOperator , or a dyn_cast maybe.


https://reviews.llvm.org/D47143





More information about the llvm-commits mailing list