[PATCH] D50054: [ARM] Allow pointer values in ARMCodeGenPrepare

[Sam Parker via Phabricator via llvm-commits]

samparker added inline comments.


================
Comment at: lib/Target/ARM/ARMCodeGenPrepare.cpp:634
+      continue;
+    if (!isa<Instruction>(V))
+      continue;
----------------
SjoerdMeijer wrote:
> Do you need to test this again? It looks like this is already done in a few place, e.g. line 588.
Good point, Leaves will contain all the non-instruction values. I should be able to remove all of these checks.


================
Comment at: test/CodeGen/ARM/arm-cgp-calls.ll:93
+; The call to safe_lshift_func takes two parameters, but they're the same value just one is zext.
+; CHECK-COMMON-LABEL: call_zext_i8_i32
+define fastcc i32 @call_zext_i8_i32(i32 %p_45, i8 zeroext %p_46) {
----------------
SjoerdMeijer wrote:
> Do you want to test something here?
That would be nice wouldn't it? :)


https://reviews.llvm.org/D50054