[PATCH] D50054: [ARM] Ignore pointer values in ARMCodeGenPrepare

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added a comment.

Nit picking the subject/description:

> Ignore pointer values in ARMCodeGenPrepare

and

> Skip pointer values so they don't unnecessarily prevent the transformation.

But pointer types are now supported types. Thus you're actually *allowing* them, not ignoring/skipping. Not only is 'allowing' a more positive twist, I also think it is clearer :)



================
Comment at: lib/Target/ARM/ARMCodeGenPrepare.cpp:634
+      continue;
+    if (!isa<Instruction>(V))
+      continue;
----------------
Do you need to test this again? It looks like this is already done in a few place, e.g. line 588.


================
Comment at: test/CodeGen/ARM/arm-cgp-calls.ll:93
+; The call to safe_lshift_func takes two parameters, but they're the same value just one is zext.
+; CHECK-COMMON-LABEL: call_zext_i8_i32
+define fastcc i32 @call_zext_i8_i32(i32 %p_45, i8 zeroext %p_46) {
----------------
Do you want to test something here?


https://reviews.llvm.org/D50054