[PATCH] D50432: [DAGCombiner] Reduce load widths of shifted masks

John Brawn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Aug 14 04:36:52 PDT 2018


john.brawn added inline comments.


================
Comment at: test/CodeGen/ARM/and-load-combine.ll:7
 
-define arm_aapcscc zeroext i1 @cmp_xor8_short_short(i16* nocapture readonly %a,
-                                                    i16* nocapture readonly %b) {
+define arm_aapcscc zeroext i1 @cmp_xor8_short_short(i16* nocapture readonly %a, i16* nocapture readonly %b) {
 ; ARM-LABEL: cmp_xor8_short_short:
----------------
It's not clear to me what the purpose of these test changes are (or the previous version). If I revert these changes then the test still pases.


================
Comment at: test/CodeGen/X86/fp128-i128.ll:44
 ; }
 define void @TestUnionLD1(fp128 %s, i64 %n) #0 {
 ; CHECK-LABEL: TestUnionLD1:
----------------
r338821 made changes to this test which means the patch fails on this file.


https://reviews.llvm.org/D50432





More information about the llvm-commits mailing list