[PATCH] D50675: [IDF] Teach Iterated Dominance Frontier to use a snapshot CFG based on a GraphDiff.

[George Burgess IV via Phabricator via llvm-commits]

george.burgess.iv added a comment.

Never touched this code, so all I can offer is a style nit. Thanks for the patch!



================
Comment at: lib/Analysis/IteratedDominanceFrontier.cpp:65
       // successor for IDF, and predecessor for Reverse IDF.
-      for (auto *Succ : children<NodeTy>(BB)) {
+      auto doWork = [&](BasicBlock *Succ) {
         DomTreeNode *SuccNode = DT.getNode(Succ);
----------------
nit: Unless this is consistent with the rest of the file, please spell this `DoWork` (there was a [llvm-dev](http://lists.llvm.org/pipermail/llvm-dev/2018-July/124466.html) thread about this recently. My interpretation is that upper-camel is winning, but I'm also slightly biased.)


Repository:
  rL LLVM

https://reviews.llvm.org/D50675