[PATCH] D50679: [BasicAA] Don't assume tail calls with byval don't alias allocas
    Reid Kleckner via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Mon Aug 13 18:18:23 PDT 2018
    
    
  
rnk added a comment.
In https://reviews.llvm.org/D50679#1198255, @hfinkel wrote:
> Ah. Good point.
>
> Please add a direct AA test case. Otherwise, LGTM.
The BasicAA test case revealed that CallSite::onlyReadsMemory doesn't check for `byval`, but it probably could. That's probably a big change that should be committed separately. I added the test with a FIXME that we should treat byval call arg uses as readonly.
https://reviews.llvm.org/D50679
    
    
More information about the llvm-commits
mailing list